Member Controls

Goto page Previous     1 2 
Developers > When there's no other BHAV...
pljonesLink to postposted: Sun May 20, 2007 7:27 pm
Avator for pljones

Member since:
 2005-04-02
From:
 London, UK
Posts:
 610

It's fairly dirty code...  pjse.FileTable.GFT.CurrentPackage is a much better thing to be using under the circumstances.  And there's no reason for currentPackage to be static...

 

currentPackage could not have been null or the button would have been disabled, though... (Of course, as it was static, something else could have reset the value elsewhere after the test had been made.  I think it must have been getting set to the package for the requested BHAV somehow - but I can't think how...) 

 

 

The PreRelease CVS branch contains the source we built the latest release from (and maybe later changes).  HEAD gets synched to PreRelease once we ship (and before any later changes!), so it's possible for it to be slightly out of date briefly but is intended to reflect the latest release. 

quaxiLink to postposted: Mon May 21, 2007 10:24 am
Avator for quaxi

Member since:
 2006-04-28
Posts:
 3154
Sorry if you got me wrong. I wasn't suggesting a code change here :) Simply explained how I altered the code to get to test this.

The code you posted looks ok, so I agree on your guess that the problem is, that currentPackage get's changed somewhere else.
pljonesLink to postposted: Mon May 21, 2007 7:38 pm
Avator for pljones

Member since:
 2005-04-02
From:
 London, UK
Posts:
 610
I was just thinking aloud whilst reading my code... :)  I've done a fix but I might go back and have another look to see why the old version wasn't working - and then was working even less...  (I can't think why I used a static variable or wrote the code as it was...)
Goto page Previous     1 2 


viewpost, 22014, 0